Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter binary files from file list #95

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

cpiber
Copy link
Contributor

@cpiber cpiber commented Mar 14, 2024

This filters binary files from 'surviving' LOC output, similar to ins,del

Also not sure if this is intended, but ins and del do not use the file_list at all, meaning also the include and exclude options do not apply...

Closes #76

@casperdcl casperdcl self-requested a review October 6, 2024 23:19
@casperdcl casperdcl added the bug label Oct 6, 2024
This filters binary files from 'surviving' LOC output, similar to
ins,del
Copy link
Owner

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the massive delay.

I like your git grep -I --name-only work-around...

And yes, it looks like #89 is a bug/request.

@casperdcl casperdcl force-pushed the surviving-filter-binary branch from 6d46e17 to 900dcef Compare October 6, 2024 23:51
@casperdcl casperdcl merged commit f736731 into casperdcl:main Oct 6, 2024
11 checks passed
@coveralls
Copy link

Coverage Status

coverage: 87.597% (+0.2%) from 87.435%
when pulling 900dcef on cpiber:surviving-filter-binary
into c482316 on casperdcl:main.

@cpiber cpiber deleted the surviving-filter-binary branch October 7, 2024 06:18
@cpiber
Copy link
Contributor Author

cpiber commented Oct 7, 2024

No worries, glad you like it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--loc=surv has more loc than --loc=ins,del (counts bin files)
3 participants